feat(security): JWT required on every API route, gated dev fallback, role checks

- main.py: global get_current_user dependency on all routers except
  /auth/login and /health; prod fail-fast startup guard rejects wildcard
  CORS, default credentials, DEV_LOGIN_ENABLED
- inventory/pm: X-User-Role header identity fallback now only active when
  PROCUREMENT_DEV_LOGIN_ENABLED=true (was unconditional in production)
- item_decisions writes + attachment deletes: require_role(
  procurement_manager, admin) — require_role was defined but never used
- config.py: ENVIRONMENT flag, comma-separated CORS_ORIGINS, no default
  Casdoor client secret/admin password, DEV_LOGIN_ENABLED=false
- frontend: authenticated file downloads (Bearer + blob) — <a href> links
  cannot send the token; FileList/QuoteDetail/AcceptModal/EditModal/
  PurchaseHistory converted; DEV_LOGIN_ENABLED build arg defaults false
- smoke tests authenticate via POST /auth/login (SMOKE_USER/SMOKE_PASSWORD)
- traefik: security headers, API rate limit, 12MB body cap (prod overlay)
- nginx client_max_body_size aligned to 12MB
This commit is contained in:
MMD
2026-09-18 22:02:09 +03:30
parent 43e317eeba
commit f7b1f7f751
16 changed files with 225 additions and 47 deletions
+45 -8
View File
@@ -1,7 +1,14 @@
"""Application configuration.
All settings can be overridden with environment variables prefixed with
``PROCUREMENT_`` (e.g. ``PROCUREMENT_DATABASE_URL=...``) or a local ``.env`` file.
``PROCUREMENT_`` (e.g. ``PROCUREMENT_DATABASE_URL=...``) or a local ``.env``
file. The docker-compose files inject them from the git-ignored ``.env`` —
real credentials never live in this repository.
``ENVIRONMENT`` is the safety switch: when it is ``"prod"``, the API runs
fail-fast startup checks (see app.main._verify_production_settings) that
refuse to boot with wildcard CORS, default credentials or dev login
enabled.
"""
from pydantic_settings import BaseSettings, SettingsConfigDict
@@ -14,7 +21,10 @@ class Settings(BaseSettings):
extra="ignore",
)
# PostgreSQL DSN — the schema (migration.sql + seed.sql) must already exist.
# "dev" (local defaults allowed) | "prod" (fail-fast checks on startup).
ENVIRONMENT: str = "dev"
# PostgreSQL DSN — the schema (migration.sql) must already exist.
DATABASE_URL: str = "postgresql+asyncpg://postgres:postgres@localhost:5432/procurement"
# Echo SQL statements to the console (dev aid).
@@ -22,6 +32,8 @@ class Settings(BaseSettings):
# MinIO object storage — invoice / proforma attachments (S3-compatible).
# Endpoint is the compose service name (`minio:9000`) inside Docker.
# Defaults are LOCAL DEV ONLY — production values come from .env and the
# prod startup checks reject them.
MINIO_ENDPOINT: str = "localhost:9000"
MINIO_ACCESS_KEY: str = "minioadmin"
MINIO_SECRET_KEY: str = "minioadmin"
@@ -36,27 +48,52 @@ class Settings(BaseSettings):
DEFAULT_PAGE_SIZE: int = 20
MAX_PAGE_SIZE: int = 100
# CORS (dev-friendly default; the frontend is a static site).
CORS_ORIGINS: list[str] = ["*"]
# CORS — comma-separated exact browser origins (NOT "*" with
# credentials; the prod checks reject wildcard). Example:
# PROCUREMENT_CORS_ORIGINS=https://aramesh.bennu-api-bahrestan.ir
CORS_ORIGINS: str = "http://localhost,http://localhost:3000,http://localhost:5173"
# Developer Mode: in-page dev login panel (frontend build arg) AND the
# X-User-Role / X-User-Name-B64 header identity fallback in the
# inventory/pm routers. MUST stay false in production.
DEV_LOGIN_ENABLED: bool = False
# Casdoor (OIDC) — JWT verification against the issuer's JWKS.
CASDOOR_ENDPOINT: str = "http://localhost:8080"
CASDOOR_ISSUER: str = "" # expected token iss claim (default: CASDOOR_ENDPOINT)
CASDOOR_CLIENT_ID: str = "inventory-app-client"
CASDOOR_CLIENT_SECRET: str = "inventory-app-secret-2026"
CASDOOR_CLIENT_SECRET: str = "" # no default secret — set via env/.env
CASDOOR_ORGANIZATION: str = "inventory"
CASDOOR_APP_NAME: str = "inventory-app"
CASDOOR_JWKS_URL: str = "" # default: {endpoint}/api/public_jwks
CASDOOR_AUDIENCE: str = "inventory-app-client" # expected token aud (falls back to client_id)
# Casdoor console admin — used by POST /users/sync to mirror Casdoor
# identities into the app's users table (dev defaults: admin / 123).
# identities into the app's users table. No default password.
CASDOOR_ADMIN_USER: str = "admin"
CASDOOR_ADMIN_PASSWORD: str = "123"
CASDOOR_ADMIN_PASSWORD: str = ""
# Inventory dev fallback (only when no Authorization header is sent).
# Inventory dev fallback defaults (only used when DEV_LOGIN_ENABLED).
INVENTORY_DEFAULT_ROLE: str = "pm"
INVENTORY_DEFAULT_PROJECT_ID: str = ""
# ---- Observability (Phase 2) -------------------------------------------
# Sentry/GlitchTip DSN — backend exception capture (empty = disabled).
SENTRY_DSN: str = ""
SENTRY_TRACES_SAMPLE_RATE: float = 0.0
# OpenPanel server-side event ingestion (empty = disabled).
OPENPANEL_API_URL: str = "" # e.g. http://openpanel-api:8080 (self-hosted)
OPENPANEL_CLIENT_ID: str = ""
OPENPANEL_CLIENT_SECRET: str = ""
@property
def cors_origin_list(self) -> list[str]:
"""Comma-separated CORS_ORIGINS → list for CORSMiddleware."""
return [o.strip() for o in self.CORS_ORIGINS.split(",") if o.strip()]
@property
def is_prod(self) -> bool:
return self.ENVIRONMENT.lower() == "prod"
settings = Settings()