refactor(catalog)!: decouple materials from categories (v2.7)
Materials are now global and category-free. The category lives only on the supplier (suppliers.category_id); every category-facing query goes through the supplier edge instead of the material row.
Schema (migration.sql + init_db DDL):
- drop the materials.category_id column, its FK, and the v2.5 first-link-wins automation (fn_derive_material_category + trg_supplier_materials_derive_category) — the DDL runs idempotently at API startup
Backend:
- GET /materials?category_id=… now filters via EXISTS(supplier_materials ⋈ suppliers.category_id)
- quote category filters (quotes list) use the quote's supplier category
- /pm/on-the-way derives the display category from the supplier of the quote
- supplier_materials links no longer derive/return a material category
- expand_service: material expand=category resolves to null (kept for contract compatibility)
- material create/update no longer validates or stores category_id; seed.py aligned
Frontend:
- material creation no longer sends category_id
- formatMaterialTitle reworked to a strict order with « . » separator: [Brand] . [Material] . [Spec 1] . [Spec 2], brand deduped when the stored name already starts with it; specs separator switched from « · » to « . »
Validated: python compile, api + frontend image builds (tsc + vite) clean; branch cut from the tip of prod_v4 (= origin/production, 5a9ef40 — the team's merge made them identical).
This commit is contained in:
@@ -379,16 +379,16 @@ async def ensure_v26(engine: AsyncEngine) -> None:
|
|||||||
"VALUES (:code, :name_fa, :dimension, :si_factor, :is_base) ON CONFLICT (code) DO NOTHING",
|
"VALUES (:code, :name_fa, :dimension, :si_factor, :is_base) ON CONFLICT (code) DO NOTHING",
|
||||||
u,
|
u,
|
||||||
)
|
)
|
||||||
# v2.5 automation triggers (idempotent — DROP + CREATE keeps them in sync).
|
# v2.5/v2.6 category decoupling from materials: drop trigger, function, and column.
|
||||||
await run_statement("DROP TRIGGER IF EXISTS trg_supplier_materials_derive_category ON supplier_materials")
|
await run_statement("DROP TRIGGER IF EXISTS trg_supplier_materials_derive_category ON supplier_materials")
|
||||||
await run_statement("""
|
await run_statement("DROP FUNCTION IF EXISTS fn_derive_material_category()")
|
||||||
CREATE TRIGGER trg_supplier_materials_derive_category
|
await run_statement("ALTER TABLE materials DROP CONSTRAINT IF EXISTS materials_category_id_fkey")
|
||||||
AFTER INSERT ON supplier_materials
|
await run_statement("ALTER TABLE materials DROP COLUMN IF EXISTS category_id")
|
||||||
FOR EACH ROW EXECUTE FUNCTION fn_derive_material_category()
|
|
||||||
""")
|
|
||||||
await run_statement("DROP TRIGGER IF EXISTS trg_item_decisions_sync_price ON item_decisions")
|
await run_statement("DROP TRIGGER IF EXISTS trg_item_decisions_sync_price ON item_decisions")
|
||||||
await run_statement("""
|
await run_statement("""
|
||||||
CREATE TRIGGER trg_item_decisions_sync_price
|
CREATE TRIGGER trg_item_decisions_sync_price
|
||||||
AFTER INSERT OR UPDATE OF status ON item_decisions
|
AFTER INSERT OR UPDATE OF status ON item_decisions
|
||||||
FOR EACH ROW EXECUTE FUNCTION fn_sync_last_quoted_price()
|
FOR EACH ROW EXECUTE FUNCTION fn_sync_last_quoted_price()
|
||||||
""")
|
""")
|
||||||
|
|
||||||
|
|||||||
@@ -130,14 +130,11 @@ class CategoryAttribute(Base):
|
|||||||
|
|
||||||
class Material(Base):
|
class Material(Base):
|
||||||
__tablename__ = "materials"
|
__tablename__ = "materials"
|
||||||
# v2.5/2.6: name is GLOBALLY unique; category_id is nullable + derived.
|
# v2.6/v2.7: name is GLOBALLY unique; decoupled from categories.
|
||||||
__table_args__ = (UniqueConstraint("name", name="uq_material_name"),)
|
__table_args__ = (UniqueConstraint("name", name="uq_material_name"),)
|
||||||
__mapper_args__ = {"eager_defaults": True}
|
__mapper_args__ = {"eager_defaults": True}
|
||||||
|
|
||||||
id: Mapped[uuid.UUID] = _uuid_pk()
|
id: Mapped[uuid.UUID] = _uuid_pk()
|
||||||
category_id: Mapped[uuid.UUID | None] = mapped_column(
|
|
||||||
ForeignKey("material_categories.id", ondelete="RESTRICT")
|
|
||||||
)
|
|
||||||
name: Mapped[str] = mapped_column(Text, nullable=False)
|
name: Mapped[str] = mapped_column(Text, nullable=False)
|
||||||
topic: Mapped[str | None] = mapped_column(Text) # تاپیک جلوی برنامه (Persian) — legacy
|
topic: Mapped[str | None] = mapped_column(Text) # تاپیک جلوی برنامه (Persian) — legacy
|
||||||
canonical_unit_id: Mapped[int] = mapped_column(
|
canonical_unit_id: Mapped[int] = mapped_column(
|
||||||
@@ -149,7 +146,6 @@ class Material(Base):
|
|||||||
DateTime(timezone=True), nullable=False, server_default=func.now(), onupdate=func.now()
|
DateTime(timezone=True), nullable=False, server_default=func.now(), onupdate=func.now()
|
||||||
)
|
)
|
||||||
|
|
||||||
category: Mapped["MaterialCategory | None"] = relationship(lazy="raise")
|
|
||||||
canonical_unit: Mapped["Unit"] = relationship(lazy="raise")
|
canonical_unit: Mapped["Unit"] = relationship(lazy="raise")
|
||||||
attribute_values: Mapped[list["MaterialAttributeValue"]] = relationship(
|
attribute_values: Mapped[list["MaterialAttributeValue"]] = relationship(
|
||||||
back_populates="material", lazy="raise", passive_deletes=True
|
back_populates="material", lazy="raise", passive_deletes=True
|
||||||
|
|||||||
@@ -18,7 +18,7 @@ from app.models.catalog import (
|
|||||||
MaterialUnit,
|
MaterialUnit,
|
||||||
Unit,
|
Unit,
|
||||||
)
|
)
|
||||||
from app.models.procurement import LineItem
|
from app.models.procurement import LineItem, Supplier, SupplierMaterial
|
||||||
from app.schemas.catalog import (
|
from app.schemas.catalog import (
|
||||||
MaterialAttributeValuesPut,
|
MaterialAttributeValuesPut,
|
||||||
MaterialCreate,
|
MaterialCreate,
|
||||||
@@ -108,7 +108,16 @@ async def list_materials(
|
|||||||
):
|
):
|
||||||
stmt = select(Material)
|
stmt = select(Material)
|
||||||
if category_id:
|
if category_id:
|
||||||
stmt = stmt.where(Material.category_id == category_id)
|
sub = (
|
||||||
|
select(1)
|
||||||
|
.select_from(SupplierMaterial)
|
||||||
|
.join(Supplier, Supplier.id == SupplierMaterial.supplier_id)
|
||||||
|
.where(
|
||||||
|
SupplierMaterial.material_id == Material.id,
|
||||||
|
Supplier.category_id == category_id,
|
||||||
|
)
|
||||||
|
)
|
||||||
|
stmt = stmt.where(exists(sub))
|
||||||
if brand_id:
|
if brand_id:
|
||||||
# WHERE EXISTS brand_materials with that brand_id
|
# WHERE EXISTS brand_materials with that brand_id
|
||||||
sub = select(1).where(
|
sub = select(1).where(
|
||||||
|
|||||||
@@ -195,17 +195,11 @@ async def pm_on_the_way(
|
|||||||
# unit / category lookups for display
|
# unit / category lookups for display
|
||||||
unit_ids = {d.LineItem.unit_id for d in decisions}
|
unit_ids = {d.LineItem.unit_id for d in decisions}
|
||||||
units = {u.id: u for u in (await db.execute(select(Unit).where(Unit.id.in_(unit_ids)))).scalars()}
|
units = {u.id: u for u in (await db.execute(select(Unit).where(Unit.id.in_(unit_ids)))).scalars()}
|
||||||
mat_ids = {d.Material.id for d in decisions}
|
sup_cat_ids = {d.Supplier.category_id for d in decisions if d.Supplier.category_id}
|
||||||
cats = {}
|
cats = {}
|
||||||
if mat_ids:
|
if sup_cat_ids:
|
||||||
rows = (
|
rows = (await db.execute(select(MaterialCategory).where(MaterialCategory.id.in_(sup_cat_ids)))).scalars().all()
|
||||||
await db.execute(
|
cats = {c.id: c for c in rows}
|
||||||
select(Material.id, MaterialCategory)
|
|
||||||
.join(MaterialCategory, MaterialCategory.id == Material.category_id)
|
|
||||||
.where(Material.id.in_(mat_ids))
|
|
||||||
)
|
|
||||||
).all()
|
|
||||||
cats = {m_id: c for m_id, c in rows}
|
|
||||||
|
|
||||||
out = []
|
out = []
|
||||||
for d, li, q, m, sup, proj in decisions:
|
for d, li, q, m, sup, proj in decisions:
|
||||||
@@ -220,7 +214,7 @@ async def pm_on_the_way(
|
|||||||
"project": {"id": str(proj.id), "name": proj.name} if proj else None,
|
"project": {"id": str(proj.id), "name": proj.name} if proj else None,
|
||||||
"decided_at": to_iso(d.decided_at),
|
"decided_at": to_iso(d.decided_at),
|
||||||
"material": {"id": str(m.id), "name": m.name,
|
"material": {"id": str(m.id), "name": m.name,
|
||||||
"category": {"id": str(c.id), "name": c.name} if (c := cats.get(m.id)) else None},
|
"category": {"id": str(c.id), "name": c.name} if (c := cats.get(sup.category_id)) else None},
|
||||||
"unit": {"id": units[li.unit_id].id, "code": units[li.unit_id].code,
|
"unit": {"id": units[li.unit_id].id, "code": units[li.unit_id].code,
|
||||||
"name_fa": units[li.unit_id].name_fa} if li.unit_id in units else None,
|
"name_fa": units[li.unit_id].name_fa} if li.unit_id in units else None,
|
||||||
"ordered_qty": str(li.quantity),
|
"ordered_qty": str(li.quantity),
|
||||||
|
|||||||
@@ -39,9 +39,8 @@ router = APIRouter(prefix="/quotes", tags=["quotes"])
|
|||||||
def _quote_category_exists(category_id) -> exists:
|
def _quote_category_exists(category_id) -> exists:
|
||||||
return exists(
|
return exists(
|
||||||
select(1).where(
|
select(1).where(
|
||||||
LineItem.quote_id == Quote.id,
|
Supplier.id == Quote.supplier_id,
|
||||||
Material.id == LineItem.material_id,
|
Supplier.category_id == category_id,
|
||||||
Material.category_id == category_id,
|
|
||||||
)
|
)
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
@@ -58,11 +58,7 @@ async def list_supplier_materials(
|
|||||||
items, meta = await paginate(stmt, page, page_size, db)
|
items, meta = await paginate(stmt, page, page_size, db)
|
||||||
mat_ids = {l.material_id for l in items}
|
mat_ids = {l.material_id for l in items}
|
||||||
materials = {m.id: m for m in (await db.execute(select(Material).where(Material.id.in_(mat_ids)))).scalars()}
|
materials = {m.id: m for m in (await db.execute(select(Material).where(Material.id.in_(mat_ids)))).scalars()}
|
||||||
cat_ids = {m.category_id for m in materials.values() if m.category_id}
|
return {"data": [link_to_dict(l, materials.get(l.material_id), None) for l in items], "meta": meta}
|
||||||
cats = {}
|
|
||||||
if cat_ids:
|
|
||||||
cats = {c.id: c for c in (await db.execute(select(MaterialCategory).where(MaterialCategory.id.in_(cat_ids)))).scalars()}
|
|
||||||
return {"data": [link_to_dict(l, materials.get(l.material_id), cats.get(materials.get(l.material_id).category_id if l.material_id in materials else None)) for l in items], "meta": meta}
|
|
||||||
|
|
||||||
|
|
||||||
@router.post("/suppliers/{supplier_id}/materials", status_code=201)
|
@router.post("/suppliers/{supplier_id}/materials", status_code=201)
|
||||||
@@ -72,8 +68,7 @@ async def create_supplier_material(
|
|||||||
async with db.begin():
|
async with db.begin():
|
||||||
link = await link_supplier_material(db, supplier_id, payload.material_id)
|
link = await link_supplier_material(db, supplier_id, payload.material_id)
|
||||||
material = await db.get(Material, payload.material_id)
|
material = await db.get(Material, payload.material_id)
|
||||||
category = await db.get(MaterialCategory, material.category_id) if material and material.category_id else None
|
return {"data": link_to_dict(link, material, None)}
|
||||||
return {"data": link_to_dict(link, material, category)}
|
|
||||||
|
|
||||||
|
|
||||||
@router.delete("/suppliers/{supplier_id}/materials/{material_id}")
|
@router.delete("/suppliers/{supplier_id}/materials/{material_id}")
|
||||||
|
|||||||
@@ -89,7 +89,6 @@ class MaterialAttributeIn(APIModel):
|
|||||||
|
|
||||||
|
|
||||||
class MaterialCreate(APIModel):
|
class MaterialCreate(APIModel):
|
||||||
category_id: UUID | None = None # v2.5: optional — derived from first linked supplier
|
|
||||||
name: str = Field(min_length=1)
|
name: str = Field(min_length=1)
|
||||||
topic: str | None = None # تاپیک جلوی برنامه (Persian) — legacy
|
topic: str | None = None # تاپیک جلوی برنامه (Persian) — legacy
|
||||||
canonical_unit_id: int
|
canonical_unit_id: int
|
||||||
|
|||||||
@@ -37,7 +37,7 @@ class SupplierUpdate(APIModel):
|
|||||||
|
|
||||||
|
|
||||||
class SupplierMaterialCreate(APIModel):
|
class SupplierMaterialCreate(APIModel):
|
||||||
"""Link a global material to a supplier (derives materials.category_id)."""
|
"""Link a global material to a supplier."""
|
||||||
|
|
||||||
material_id: UUID
|
material_id: UUID
|
||||||
|
|
||||||
|
|||||||
@@ -206,11 +206,6 @@ async def _load_material_maps(db: AsyncSession, materials: list[Material], expan
|
|||||||
material_ids = [m.id for m in materials]
|
material_ids = [m.id for m in materials]
|
||||||
maps: dict = {"categories": {}, "units": {}, "brands": {}, "material_brands": {}, "mavs": {}, "attr_defs": {}}
|
maps: dict = {"categories": {}, "units": {}, "brands": {}, "material_brands": {}, "mavs": {}, "attr_defs": {}}
|
||||||
|
|
||||||
if "category" in expand:
|
|
||||||
cat_ids = {m.category_id for m in materials}
|
|
||||||
rows = (await db.execute(select(MaterialCategory).where(MaterialCategory.id.in_(cat_ids)))).scalars().all()
|
|
||||||
maps["categories"] = {c.id: c for c in rows}
|
|
||||||
|
|
||||||
unit_ids: set[int] = set()
|
unit_ids: set[int] = set()
|
||||||
if "canonical_unit" in expand:
|
if "canonical_unit" in expand:
|
||||||
unit_ids |= {m.canonical_unit_id for m in materials}
|
unit_ids |= {m.canonical_unit_id for m in materials}
|
||||||
@@ -258,9 +253,9 @@ def _material_to_dict(m: Material, expand: set[str], maps: dict) -> dict:
|
|||||||
"updated_at": to_iso(m.updated_at),
|
"updated_at": to_iso(m.updated_at),
|
||||||
}
|
}
|
||||||
if "category" in expand:
|
if "category" in expand:
|
||||||
d["category"] = category_brief(maps["categories"].get(m.category_id))
|
d["category"] = None
|
||||||
else:
|
else:
|
||||||
d["category_id"] = str(m.category_id)
|
d["category_id"] = None
|
||||||
if "canonical_unit" in expand:
|
if "canonical_unit" in expand:
|
||||||
d["canonical_unit"] = unit_to_dict(maps["units"].get(m.canonical_unit_id))
|
d["canonical_unit"] = unit_to_dict(maps["units"].get(m.canonical_unit_id))
|
||||||
else:
|
else:
|
||||||
@@ -326,9 +321,6 @@ async def _load_line_item_data(db: AsyncSession, line_items: list[LineItem], exp
|
|||||||
material_ids = {li.material_id for li in line_items}
|
material_ids = {li.material_id for li in line_items}
|
||||||
materials = (await db.execute(select(Material).where(Material.id.in_(material_ids)))).scalars().all()
|
materials = (await db.execute(select(Material).where(Material.id.in_(material_ids)))).scalars().all()
|
||||||
data.materials = {m.id: m for m in materials}
|
data.materials = {m.id: m for m in materials}
|
||||||
cat_ids = {m.category_id for m in materials}
|
|
||||||
cats = (await db.execute(select(MaterialCategory).where(MaterialCategory.id.in_(cat_ids)))).scalars().all()
|
|
||||||
data.categories = {c.id: c for c in cats}
|
|
||||||
bms = (await db.execute(select(BrandMaterial).where(BrandMaterial.material_id.in_(material_ids)))).scalars().all()
|
bms = (await db.execute(select(BrandMaterial).where(BrandMaterial.material_id.in_(material_ids)))).scalars().all()
|
||||||
brand_ids: set[uuid.UUID] = set()
|
brand_ids: set[uuid.UUID] = set()
|
||||||
for bm in bms:
|
for bm in bms:
|
||||||
@@ -450,7 +442,7 @@ def _line_item_expanded(li: LineItem, expand: set[str], data: _LineItemData, inc
|
|||||||
d["material"] = {
|
d["material"] = {
|
||||||
"id": str(m.id),
|
"id": str(m.id),
|
||||||
"name": m.name,
|
"name": m.name,
|
||||||
"category": category_brief(data.categories.get(m.category_id)),
|
"category": None,
|
||||||
"brands": [
|
"brands": [
|
||||||
{"id": str(bm.brand_id), "name": data.brands[bm.brand_id].name, "catalog_code": bm.catalog_code}
|
{"id": str(bm.brand_id), "name": data.brands[bm.brand_id].name, "catalog_code": bm.catalog_code}
|
||||||
for bm in data.material_brands.get(m.id, [])
|
for bm in data.material_brands.get(m.id, [])
|
||||||
|
|||||||
@@ -12,7 +12,6 @@ from app.models.catalog import (
|
|||||||
BrandMaterial,
|
BrandMaterial,
|
||||||
Material,
|
Material,
|
||||||
MaterialAttributeValue,
|
MaterialAttributeValue,
|
||||||
MaterialCategory,
|
|
||||||
Unit,
|
Unit,
|
||||||
)
|
)
|
||||||
from app.schemas.catalog import MaterialAttributeIn, MaterialCreate, MaterialUpdate
|
from app.schemas.catalog import MaterialAttributeIn, MaterialCreate, MaterialUpdate
|
||||||
@@ -110,9 +109,7 @@ async def validate_attributes(
|
|||||||
async def create_material(db: AsyncSession, payload: MaterialCreate) -> Material:
|
async def create_material(db: AsyncSession, payload: MaterialCreate) -> Material:
|
||||||
"""Create a material + brand_materials rows + EAV values in ONE transaction.
|
"""Create a material + brand_materials rows + EAV values in ONE transaction.
|
||||||
|
|
||||||
v2.5/2.6: category_id is OPTIONAL — a global material may be created
|
v2.6/v2.7: materials are global and category-free. name is GLOBALLY unique.
|
||||||
without a category (it gets derived automatically from the first linked
|
|
||||||
supplier). name is GLOBALLY unique.
|
|
||||||
"""
|
"""
|
||||||
async with db.begin():
|
async with db.begin():
|
||||||
duplicate = await db.scalar(
|
duplicate = await db.scalar(
|
||||||
@@ -121,14 +118,10 @@ async def create_material(db: AsyncSession, payload: MaterialCreate) -> Material
|
|||||||
if duplicate is not None:
|
if duplicate is not None:
|
||||||
raise ConflictError("متریالی با این نام در کل کاتالوگ قبلاً ثبت شده است", field="name")
|
raise ConflictError("متریالی با این نام در کل کاتالوگ قبلاً ثبت شده است", field="name")
|
||||||
|
|
||||||
if payload.category_id is not None:
|
|
||||||
if await db.get(MaterialCategory, payload.category_id) is None:
|
|
||||||
raise NotFoundError("دستهبندی یافت نشد", field="category_id")
|
|
||||||
if not await db.get(Unit, payload.canonical_unit_id):
|
if not await db.get(Unit, payload.canonical_unit_id):
|
||||||
raise NotFoundError("واحد مرجع یافت نشد", field="canonical_unit_id")
|
raise NotFoundError("واحد مرجع یافت نشد", field="canonical_unit_id")
|
||||||
|
|
||||||
material = Material(
|
material = Material(
|
||||||
category_id=payload.category_id,
|
|
||||||
name=payload.name,
|
name=payload.name,
|
||||||
topic=payload.topic,
|
topic=payload.topic,
|
||||||
canonical_unit_id=payload.canonical_unit_id,
|
canonical_unit_id=payload.canonical_unit_id,
|
||||||
|
|||||||
@@ -903,15 +903,12 @@ async def quote_stats(
|
|||||||
|
|
||||||
|
|
||||||
def _quote_has_category(category_id: UUID):
|
def _quote_has_category(category_id: UUID):
|
||||||
"""EXISTS: quote has a line item whose material belongs to category_id."""
|
"""EXISTS: quote's supplier belongs to category_id."""
|
||||||
from app.models.catalog import Material
|
|
||||||
|
|
||||||
sub = (
|
sub = (
|
||||||
select(1)
|
select(1)
|
||||||
.where(
|
.where(
|
||||||
LineItem.quote_id == Quote.id,
|
Supplier.id == Quote.supplier_id,
|
||||||
Material.id == LineItem.material_id,
|
Supplier.category_id == category_id,
|
||||||
Material.category_id == category_id,
|
|
||||||
)
|
)
|
||||||
)
|
)
|
||||||
return func.exists(sub)
|
return func.exists(sub)
|
||||||
|
|||||||
@@ -1,10 +1,6 @@
|
|||||||
"""Supplier ↔ material link service (v2.5) — the direct edge of the new flow.
|
"""Supplier ↔ material link service (v2.6/v2.7) — the direct edge of the catalog flow.
|
||||||
|
|
||||||
Linking a material to a supplier derives materials.category_id from the
|
Suppliers can supply any global material across categories.
|
||||||
supplier's category when the material has none (first-link-wins). The same
|
|
||||||
rule is enforced by the DB trigger trg_supplier_materials_derive_category;
|
|
||||||
this service applies it in the application layer so the ORM state is
|
|
||||||
consistent inside the same transaction.
|
|
||||||
"""
|
"""
|
||||||
from sqlalchemy import select
|
from sqlalchemy import select
|
||||||
from sqlalchemy.ext.asyncio import AsyncSession
|
from sqlalchemy.ext.asyncio import AsyncSession
|
||||||
@@ -17,7 +13,7 @@ from app.utils.errors import NotFoundError, ValidationError
|
|||||||
async def link_supplier_material(
|
async def link_supplier_material(
|
||||||
db: AsyncSession, supplier_id, material_id, is_active: bool = True
|
db: AsyncSession, supplier_id, material_id, is_active: bool = True
|
||||||
) -> SupplierMaterial:
|
) -> SupplierMaterial:
|
||||||
"""Upsert a supplier<->material link (idempotent) + derive category (first-link-wins).
|
"""Upsert a supplier<->material link (idempotent).
|
||||||
|
|
||||||
Caller is responsible for the surrounding transaction.
|
Caller is responsible for the surrounding transaction.
|
||||||
"""
|
"""
|
||||||
@@ -42,15 +38,11 @@ async def link_supplier_material(
|
|||||||
link = SupplierMaterial(supplier_id=supplier_id, material_id=material_id, is_active=is_active)
|
link = SupplierMaterial(supplier_id=supplier_id, material_id=material_id, is_active=is_active)
|
||||||
db.add(link)
|
db.add(link)
|
||||||
await db.flush()
|
await db.flush()
|
||||||
|
|
||||||
# First-link-wins: only when the material has no category yet.
|
|
||||||
if material.category_id is None:
|
|
||||||
material.category_id = supplier.category_id
|
|
||||||
return link
|
return link
|
||||||
|
|
||||||
|
|
||||||
async def unlink_supplier_material(db: AsyncSession, supplier_id, material_id) -> None:
|
async def unlink_supplier_material(db: AsyncSession, supplier_id, material_id) -> None:
|
||||||
"""Remove the link. The material's category is NEVER auto-cleared (documented rule)."""
|
"""Remove the link."""
|
||||||
link = await db.scalar(
|
link = await db.scalar(
|
||||||
select(SupplierMaterial).where(
|
select(SupplierMaterial).where(
|
||||||
SupplierMaterial.supplier_id == supplier_id,
|
SupplierMaterial.supplier_id == supplier_id,
|
||||||
|
|||||||
@@ -261,9 +261,7 @@ async def run() -> None:
|
|||||||
material_by_name: dict[str, Material] = {}
|
material_by_name: dict[str, Material] = {}
|
||||||
brand_material_by_material: dict[str, object] = {}
|
brand_material_by_material: dict[str, object] = {}
|
||||||
for name, cat_slug, unit_code, brand_name in MATERIALS:
|
for name, cat_slug, unit_code, brand_name in MATERIALS:
|
||||||
cat = await get_category(db, cat_slug)
|
|
||||||
material = Material(
|
material = Material(
|
||||||
category_id=cat.id,
|
|
||||||
name=name,
|
name=name,
|
||||||
canonical_unit_id=unit_ids[unit_code],
|
canonical_unit_id=unit_ids[unit_code],
|
||||||
status="active",
|
status="active",
|
||||||
@@ -289,8 +287,10 @@ async def run() -> None:
|
|||||||
await db.flush()
|
await db.flush()
|
||||||
suppliers.append(sup)
|
suppliers.append(sup)
|
||||||
# last-quoted prices: link each supplier to 2 materials of its category
|
# last-quoted prices: link each supplier to 2 materials of its category
|
||||||
|
sup_cat_slug = {name: cat_slug for name, cat_slug, *_ in SUPPLIERS}
|
||||||
for sup in suppliers:
|
for sup in suppliers:
|
||||||
cat_materials = [m for m in material_by_name.values() if m.category_id == sup.category_id]
|
target_slug = sup_cat_slug.get(sup.name)
|
||||||
|
cat_materials = [material_by_name[mat_name] for mat_name, c_slug, *_ in MATERIALS if c_slug == target_slug]
|
||||||
for m in cat_materials[:2]:
|
for m in cat_materials[:2]:
|
||||||
db.add(SupplierMaterial(
|
db.add(SupplierMaterial(
|
||||||
supplier_id=sup.id, material_id=m.id, is_active=True,
|
supplier_id=sup.id, material_id=m.id, is_active=True,
|
||||||
|
|||||||
@@ -1108,12 +1108,6 @@ export const api = {
|
|||||||
},
|
},
|
||||||
create: async (m: Material): Promise<Material> => {
|
create: async (m: Material): Promise<Material> => {
|
||||||
const lookup = await fetchLookup();
|
const lookup = await fetchLookup();
|
||||||
// v2.5: category_id اختیاری است — اگر نامِ تایپشده یکی از ۸ دستهی ثابت
|
|
||||||
// نباشد، متریال بهصورت سراسری (بدون دسته) ساخته میشود و دستهاش بعداً
|
|
||||||
// از اولین تأمینکنندهی مرتبط استنتاج میشود (first-link-wins).
|
|
||||||
// دستهی rogue دیگر هرگز ساخته نمیشود — فقط تطبیق با ۸ دستهی موجود؛
|
|
||||||
// در صورت نبود تطبیق، خطا نمیدهیم و category_id را null میفرستیم.
|
|
||||||
const categoryId = m.category ? lookup.categoryNameToId.get(norm(m.category)) : undefined;
|
|
||||||
// واحد مرجع — بدون مقدار پیشفرض؛ متریال بدون واحدِ صریح ساخته نمیشود
|
// واحد مرجع — بدون مقدار پیشفرض؛ متریال بدون واحدِ صریح ساخته نمیشود
|
||||||
// (بکاند canonical_unit_id را الزامی میداند)
|
// (بکاند canonical_unit_id را الزامی میداند)
|
||||||
const unitName = (m.base_unit || "").trim();
|
const unitName = (m.base_unit || "").trim();
|
||||||
@@ -1138,7 +1132,6 @@ export const api = {
|
|||||||
if (defId) attrs.push({ attribute_definition_id: defId, value: spec });
|
if (defId) attrs.push({ attribute_definition_id: defId, value: spec });
|
||||||
}
|
}
|
||||||
const raw = await postData<RawMaterial>("/materials", {
|
const raw = await postData<RawMaterial>("/materials", {
|
||||||
category_id: categoryId ?? null,
|
|
||||||
name,
|
name,
|
||||||
topic: m.topic || null,
|
topic: m.topic || null,
|
||||||
canonical_unit_id: unitId,
|
canonical_unit_id: unitId,
|
||||||
@@ -1760,7 +1753,6 @@ export const apiV26 = {
|
|||||||
}): Promise<{ id: string; name: string }> =>
|
}): Promise<{ id: string; name: string }> =>
|
||||||
postData("/materials", {
|
postData("/materials", {
|
||||||
name: opts.name,
|
name: opts.name,
|
||||||
category_id: null, // دسته از اولین تأمینکنندهی مرتبط استنتاج میشود (v2.5)
|
|
||||||
topic: null,
|
topic: null,
|
||||||
canonical_unit_id: opts.canonical_unit_id,
|
canonical_unit_id: opts.canonical_unit_id,
|
||||||
status: "active",
|
status: "active",
|
||||||
|
|||||||
@@ -35,43 +35,51 @@ export function specsKey(specs: string[]): string {
|
|||||||
return (specs || []).map((s) => normalize(s)).filter(Boolean).sort().join("|");
|
return (specs || []).map((s) => normalize(s)).filter(Boolean).sort().join("|");
|
||||||
}
|
}
|
||||||
|
|
||||||
// specها با جداکنندهی « · »
|
// specها با جداکنندهی « . »
|
||||||
export function specsLabel(specs: string[]): string {
|
export function specsLabel(specs: string[]): string {
|
||||||
return specs.join(" · ");
|
return specs.join(" . ");
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* عنوان تمیز و بدون تکرار کالا:
|
* عنوان تمیز و بدون تکرار کالا:
|
||||||
* ترکیب هوشمندانهی نام اصلی (materials.name)، برند، و مشخصهها بدون تکرار کلمات مشترک.
|
* ترتیب اکید با جداکنندهی نقطه:
|
||||||
|
* [نام برند] . [نام متریال] . [مشخصه ۱] . [مشخصه ۲]
|
||||||
*/
|
*/
|
||||||
export function formatMaterialTitle(
|
export function formatMaterialTitle(
|
||||||
m: Pick<Material, "name" | "brand" | "specs" | "category"> | null | undefined,
|
m: Pick<Material, "name" | "brand" | "specs" | "category"> | null | undefined,
|
||||||
extraSpecs?: string[],
|
extraSpecs?: string[],
|
||||||
): string {
|
): string {
|
||||||
if (!m) return "کالا";
|
if (!m) return "کالا";
|
||||||
const rawName = (m.name || "").trim();
|
let rawName = (m.name || "").trim();
|
||||||
const rawBrand = (m.brand || "").trim();
|
const rawBrand = (m.brand || "").trim();
|
||||||
const rawSpecs = [...(m.specs || []), ...(extraSpecs || [])]
|
const rawSpecs = [...(m.specs || []), ...(extraSpecs || [])]
|
||||||
.map((s) => (s || "").trim())
|
.map((s) => (s || "").trim())
|
||||||
.filter(Boolean);
|
.filter(Boolean);
|
||||||
|
|
||||||
const normName = normalize(rawName);
|
|
||||||
const normBrand = normalize(rawBrand);
|
const normBrand = normalize(rawBrand);
|
||||||
|
|
||||||
if (!rawName) {
|
// اگر نام کالا با نام برند شروع شده باشد، برند را از ابتدای نام برمیداریم تا تکرار نشود
|
||||||
if (rawBrand && rawSpecs.length) return `${rawBrand} · ${rawSpecs.join(" · ")}`;
|
if (normBrand && rawName) {
|
||||||
if (rawBrand) return rawBrand;
|
const normName = normalize(rawName);
|
||||||
if (rawSpecs.length) return rawSpecs.join(" · ");
|
if (normName.startsWith(normBrand)) {
|
||||||
return m.category && m.category !== "؟" ? m.category : "کالا";
|
const rest = rawName.slice(rawBrand.length).trim();
|
||||||
|
rawName = rest.replace(/^[.\s·\-]+/, "").trim();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
let title = rawName;
|
// قطعات نهایی با ترتیب مشخص: [Brand Name] . [Material Name] . [Specification 1] . [Specification 2]
|
||||||
if (normBrand && !normName.includes(normBrand)) {
|
const parts: string[] = [];
|
||||||
title = `${rawBrand} ${title}`;
|
if (rawBrand) {
|
||||||
|
parts.push(rawBrand);
|
||||||
|
}
|
||||||
|
if (rawName) {
|
||||||
|
parts.push(rawName);
|
||||||
|
} else if (!rawBrand) {
|
||||||
|
parts.push(m.category && m.category !== "؟" ? m.category : "کالا");
|
||||||
}
|
}
|
||||||
|
|
||||||
const normTitle = normalize(title);
|
// اضافه کردن مشخصهها بدون تکرار
|
||||||
const distinctSpecs: string[] = [];
|
const normCurrent = normalize(parts.join(" "));
|
||||||
const seenNormSpecs = new Set<string>();
|
const seenNormSpecs = new Set<string>();
|
||||||
|
|
||||||
for (const s of rawSpecs) {
|
for (const s of rawSpecs) {
|
||||||
@@ -79,15 +87,12 @@ export function formatMaterialTitle(
|
|||||||
if (!ns || seenNormSpecs.has(ns)) continue;
|
if (!ns || seenNormSpecs.has(ns)) continue;
|
||||||
seenNormSpecs.add(ns);
|
seenNormSpecs.add(ns);
|
||||||
|
|
||||||
// اگر مشخصه قبلاً داخل عنوان یا نام کالا آمده باشد، تکرار نمیکنیم
|
// اگر مشخصه قبلاً داخل نام یا برند آمده باشد، تکرار نمیکنیم
|
||||||
if (normTitle.includes(ns)) continue;
|
if (normCurrent.includes(ns)) continue;
|
||||||
distinctSpecs.push(s);
|
parts.push(s);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (distinctSpecs.length > 0) {
|
return parts.join(" . ");
|
||||||
return `${title} · ${distinctSpecs.join(" · ")}`;
|
|
||||||
}
|
|
||||||
return title;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export function materialLabel(m: Pick<Material, "name" | "brand" | "specs" | "category"> | null | undefined): string {
|
export function materialLabel(m: Pick<Material, "name" | "brand" | "specs" | "category"> | null | undefined): string {
|
||||||
|
|||||||
@@ -20,9 +20,9 @@ export interface Supplier {
|
|||||||
// ماده/کالا
|
// ماده/کالا
|
||||||
export interface Material {
|
export interface Material {
|
||||||
id: string; // "m1", "m2", ...
|
id: string; // "m1", "m2", ...
|
||||||
name: string; // نام کامل ذخیرهشده در بکاند (برند + دسته + مشخصه)
|
name: string; // نام کامل ذخیرهشده در بکاند (برند + مشخصه)
|
||||||
topic: string;
|
topic: string;
|
||||||
category: string; // مثلاً "میلگرد"
|
category: string; // اختیاری در بکاند؛ همیشه string در فرانت (default: "")
|
||||||
brand: string; // مثلاً "ذوب آهن"
|
brand: string; // مثلاً "ذوب آهن"
|
||||||
specs: string[]; // آرایهای از مشخصهها (مثلاً ["A2"])
|
specs: string[]; // آرایهای از مشخصهها (مثلاً ["A2"])
|
||||||
base_unit: string; // واحد پایه
|
base_unit: string; // واحد پایه
|
||||||
|
|||||||
@@ -3,7 +3,6 @@ import { AlarmClock, ChevronDown, Pencil, TriangleAlert, Building2, Package, Cre
|
|||||||
import type { Quote, Store } from "../../lib/types";
|
import type { Quote, Store } from "../../lib/types";
|
||||||
import {
|
import {
|
||||||
isExpired,
|
isExpired,
|
||||||
itemsSummary,
|
|
||||||
materialById,
|
materialById,
|
||||||
materialLabel,
|
materialLabel,
|
||||||
projectCell,
|
projectCell,
|
||||||
@@ -44,7 +43,6 @@ export function QuoteCard({ store, q, expanded, onToggleExpand, onAccept, onEdit
|
|||||||
const pc = priceCell(total);
|
const pc = priceCell(total);
|
||||||
const ts = termsheetSummary(store, q);
|
const ts = termsheetSummary(store, q);
|
||||||
const unitWarns = unitWarning(store, q);
|
const unitWarns = unitWarning(store, q);
|
||||||
const summary = itemsSummary(store, q);
|
|
||||||
|
|
||||||
// ستون / دکمه پذیرش
|
// ستون / دکمه پذیرش
|
||||||
let acceptedCell: React.ReactNode;
|
let acceptedCell: React.ReactNode;
|
||||||
@@ -188,47 +186,22 @@ export function QuoteCard({ store, q, expanded, onToggleExpand, onAccept, onEdit
|
|||||||
</div>
|
</div>
|
||||||
</InfoCell>
|
</InfoCell>
|
||||||
|
|
||||||
{/* ۲. اقلام — تمامعرض زیر پروژه با شکستن متن بدون سهنقطه */}
|
{/* ۲. اقلام — نمایش عمودی چندخطی */}
|
||||||
<InfoCell label="اقلام" className="col-span-2 md:col-span-1">
|
<InfoCell label="اقلام" className="col-span-2 md:col-span-1">
|
||||||
{summary.count > 1 ? (
|
<div className="flex flex-col gap-1 text-xs font-medium leading-5 text-ink sm:text-[13px]">
|
||||||
<div className="flex flex-col gap-1.5">
|
{activeItems.length > 0 ? (
|
||||||
<span className="font-bold text-xs text-ink sm:text-sm">
|
activeItems.map((li) => {
|
||||||
{fmtNum(summary.count)} قلم کالا
|
const m = materialById(store.materials, li.material_id);
|
||||||
</span>
|
return (
|
||||||
<div className="flex flex-col gap-1.5 rounded-lg border border-line/60 bg-bg/50 p-2.5 text-[11px] leading-5 text-muted sm:text-[11.5px]">
|
<span key={li.id} className="break-words">
|
||||||
{store.quotes
|
{materialLabel(m)}
|
||||||
.find((x) => x.id === q.id)
|
|
||||||
?.line_items?.filter((li) => !li.rejected)
|
|
||||||
.slice(0, 3)
|
|
||||||
.map((li) => {
|
|
||||||
const m = materialById(store.materials, li.material_id);
|
|
||||||
return (
|
|
||||||
<div
|
|
||||||
key={li.id}
|
|
||||||
className="flex items-start justify-between gap-2 border-b border-line/30 pb-1.5 last:border-0 last:pb-0"
|
|
||||||
>
|
|
||||||
<span className="min-w-0 flex-1 font-medium text-ink leading-snug break-words">
|
|
||||||
• {materialLabel(m)}
|
|
||||||
</span>
|
|
||||||
<span className="shrink-0 font-semibold tabular-nums text-ink text-[10.5px] pt-0.5">
|
|
||||||
{fmtNum(li.quantity)}{" "}
|
|
||||||
<span className="font-normal text-muted text-[9.5px]">{li.unit}</span>
|
|
||||||
</span>
|
|
||||||
</div>
|
|
||||||
);
|
|
||||||
})}
|
|
||||||
{(q.line_items?.length || 0) > 3 && (
|
|
||||||
<span className="pt-0.5 text-[10px] text-muted">
|
|
||||||
و {(q.line_items?.length || 0) - 3} قلم دیگر...
|
|
||||||
</span>
|
</span>
|
||||||
)}
|
);
|
||||||
</div>
|
})
|
||||||
</div>
|
) : (
|
||||||
) : (
|
<span>—</span>
|
||||||
<div className="flex items-start gap-1.5 text-xs font-medium leading-5 text-ink sm:text-[13px]">
|
)}
|
||||||
<span className="break-words">{summary.text}</span>
|
</div>
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
|
|
||||||
{unitWarns.map((w) => (
|
{unitWarns.map((w) => (
|
||||||
<Link
|
<Link
|
||||||
@@ -243,32 +216,6 @@ export function QuoteCard({ store, q, expanded, onToggleExpand, onAccept, onEdit
|
|||||||
))}
|
))}
|
||||||
</InfoCell>
|
</InfoCell>
|
||||||
|
|
||||||
<InfoCell label="پروژه">
|
|
||||||
<span className="inline-flex items-center gap-1 text-xs sm:text-[13px]">
|
|
||||||
<Building2 className="h-3.5 w-3.5 shrink-0 text-muted" />
|
|
||||||
<span className="truncate">
|
|
||||||
{(() => {
|
|
||||||
const activeItems = (q.line_items || []).filter((li) => !li.rejected);
|
|
||||||
if (q.status === "accepted" || q.status === "arrived") {
|
|
||||||
// فقط پروژهی هدف پذیرفتهشده — همان منطق itemProjects در وضعیت accepted
|
|
||||||
const targetProj = activeItems.find((li) => li.target_project)?.target_project;
|
|
||||||
return targetProj?.name ?? projectCell(q);
|
|
||||||
}
|
|
||||||
// وضعیت offered: همهی پروژههای کاندیدا از line_items (همان منطق itemProjects)
|
|
||||||
const names = new Set<string>();
|
|
||||||
activeItems.forEach((li) =>
|
|
||||||
(li.projects || []).forEach((p) => {
|
|
||||||
const name = typeof p === "string" ? p : p.name;
|
|
||||||
if (name) names.add(name);
|
|
||||||
})
|
|
||||||
);
|
|
||||||
if (names.size > 0) return [...names].join("، ");
|
|
||||||
return projectCell(q);
|
|
||||||
})()}
|
|
||||||
</span>
|
|
||||||
</span>
|
|
||||||
</InfoCell>
|
|
||||||
|
|
||||||
<InfoCell label="مجموع مبلغ" className="col-span-1">
|
<InfoCell label="مجموع مبلغ" className="col-span-1">
|
||||||
{pc ? (
|
{pc ? (
|
||||||
<div>
|
<div>
|
||||||
|
|||||||
@@ -67,17 +67,18 @@ function materialBaseName(name: string, brand: string, specs: string[], category
|
|||||||
return base || fallback;
|
return base || fallback;
|
||||||
}
|
}
|
||||||
|
|
||||||
// مقادیر مجزای category/brand/spec داخل تاپیک
|
// مقادیر مجزای category/brand/spec در کاتالوگ سراسری
|
||||||
export function materialOptions(
|
export function materialOptions(
|
||||||
materials: Material[],
|
materials: Material[],
|
||||||
topic: string,
|
_topic: string,
|
||||||
item: ItemDraft,
|
item: ItemDraft,
|
||||||
field: "cat" | "brand" | "spec",
|
field: "cat" | "brand" | "spec",
|
||||||
allItems: ItemDraft[] = [],
|
allItems: ItemDraft[] = [],
|
||||||
apiBrands: string[] = [],
|
apiBrands: string[] = [],
|
||||||
apiSpecs: string[] = [],
|
apiSpecs: string[] = [],
|
||||||
): string[] {
|
): string[] {
|
||||||
let list = materials.filter((m) => topic && normalize(m.topic) === normalize(topic));
|
// متریالها سراسری هستند — مستقل از تاپیک
|
||||||
|
let list = materials;
|
||||||
const cat = item.cat.trim();
|
const cat = item.cat.trim();
|
||||||
|
|
||||||
const fromRows = (sel: (it: ItemDraft) => string | string[]): string[] => {
|
const fromRows = (sel: (it: ItemDraft) => string | string[]): string[] => {
|
||||||
@@ -92,7 +93,7 @@ export function materialOptions(
|
|||||||
};
|
};
|
||||||
|
|
||||||
if (field === "cat") {
|
if (field === "cat") {
|
||||||
const base = new Set(list.map((m) => m.category).filter(Boolean));
|
const base = new Set<string>(materials.map((m) => m.category).filter(Boolean));
|
||||||
fromRows((it) => it.cat).forEach((c) => base.add(c));
|
fromRows((it) => it.cat).forEach((c) => base.add(c));
|
||||||
return [...base].sort((a, b) => a.localeCompare(b, "fa"));
|
return [...base].sort((a, b) => a.localeCompare(b, "fa"));
|
||||||
}
|
}
|
||||||
|
|||||||
+2
-22
@@ -164,14 +164,12 @@ CREATE TABLE category_attributes (
|
|||||||
CONSTRAINT uq_category_attribute UNIQUE (category_id, attribute_definition_id)
|
CONSTRAINT uq_category_attribute UNIQUE (category_id, attribute_definition_id)
|
||||||
);
|
);
|
||||||
|
|
||||||
-- ---------- MATERIALS (GLOBAL catalog entities — v2.5) ----------
|
-- ---------- MATERIALS (GLOBAL catalog entities — v2.6/v2.7) ----------
|
||||||
-- category_id is NULLABLE and DERIVED automatically from the first linked
|
-- Materials are global, category-free entities. name is GLOBALLY
|
||||||
-- supplier (supplier_materials insert, first-link-wins). name is GLOBALLY
|
|
||||||
-- unique (uq_material_name). topic is a legacy display column no longer
|
-- unique (uq_material_name). topic is a legacy display column no longer
|
||||||
-- written by the app.
|
-- written by the app.
|
||||||
CREATE TABLE materials (
|
CREATE TABLE materials (
|
||||||
id UUID NOT NULL DEFAULT gen_random_uuid() PRIMARY KEY,
|
id UUID NOT NULL DEFAULT gen_random_uuid() PRIMARY KEY,
|
||||||
category_id UUID REFERENCES material_categories(id) ON DELETE RESTRICT,
|
|
||||||
name TEXT NOT NULL,
|
name TEXT NOT NULL,
|
||||||
topic TEXT, -- LEGACY display column
|
topic TEXT, -- LEGACY display column
|
||||||
canonical_unit_id INTEGER NOT NULL REFERENCES units(id) ON DELETE RESTRICT,
|
canonical_unit_id INTEGER NOT NULL REFERENCES units(id) ON DELETE RESTRICT,
|
||||||
@@ -585,24 +583,6 @@ CREATE TRIGGER trg_quote_attachments_updated_at
|
|||||||
-- AUTOMATION TRIGGERS (v2.5 + v2.6)
|
-- AUTOMATION TRIGGERS (v2.5 + v2.6)
|
||||||
-- ============================================================================
|
-- ============================================================================
|
||||||
|
|
||||||
-- Derive materials.category_id from the FIRST linked supplier (first-link-wins).
|
|
||||||
-- Idempotent: only touches rows where category_id IS NULL.
|
|
||||||
CREATE OR REPLACE FUNCTION fn_derive_material_category()
|
|
||||||
RETURNS TRIGGER AS $$
|
|
||||||
BEGIN
|
|
||||||
UPDATE materials
|
|
||||||
SET category_id = (SELECT category_id FROM suppliers WHERE id = NEW.supplier_id),
|
|
||||||
updated_at = now()
|
|
||||||
WHERE id = NEW.material_id
|
|
||||||
AND category_id IS NULL;
|
|
||||||
RETURN NEW;
|
|
||||||
END;
|
|
||||||
$$ LANGUAGE plpgsql;
|
|
||||||
|
|
||||||
CREATE TRIGGER trg_supplier_materials_derive_category
|
|
||||||
AFTER INSERT ON supplier_materials
|
|
||||||
FOR EACH ROW EXECUTE FUNCTION fn_derive_material_category();
|
|
||||||
|
|
||||||
-- Sync supplier_materials.last_quoted_price / last_quoted_at when an item
|
-- Sync supplier_materials.last_quoted_price / last_quoted_at when an item
|
||||||
-- decision becomes 'chosen' (INSERT or UPDATE — the accept-quote flow
|
-- decision becomes 'chosen' (INSERT or UPDATE — the accept-quote flow
|
||||||
-- inserts decisions directly as 'chosen').
|
-- inserts decisions directly as 'chosen').
|
||||||
|
|||||||
Reference in New Issue
Block a user